lkml.org 
[lkml]   [2005]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH -mm2] net: Fix compiler-error on dgrs.c when !CONFIG_PCI
    From
    On Mon, Nov 21, 2005 at 01:52:49PM +0100, Richard Knutsson wrote:
    >
    > What do you think about this patch? Will you sign it? It is no longer an
    > error-warning-fix but a bug-fix (and some cleanup).
    > I "took" you implementation of dgrs_(un)register_eisa(), especially
    > since eisa needed to be unregistered if pci succeeds (I take you word
    > for it to be so).
    > (BTW, this patch is compiled with CONFIG_PCI set, CONFIG_EISA set and
    > both set without errors/warnings for dgrs.o.)
    >
    > This patch requirer the
    > "net-fix-compiler-error-on-dgrsc-when-config_pci.patch" (added to the
    > -mm tree after 2.6.15-rc1-mm2):
    >
    > ---
    > devel/drivers/net/dgrs.c~net-fix-compiler-error-on-dgrsc-when-config_pci
    > 2005-11-19 18:00:34.000000000 -0800
    > +++ devel-akpm/drivers/net/dgrs.c 2005-11-19 18:00:34.000000000 -0800
    > @@ -1458,6 +1458,8 @@ static struct pci_driver dgrs_pci_driver
    > .probe = dgrs_pci_probe,
    > .remove = __devexit_p(dgrs_pci_remove),
    > };
    > +#else
    > +static struct pci_driver dgrs_pci_driver = {};
    > #endif

    I don't see the point. We shouldn't have this structure at all
    if CONFIG_PCI is not set.

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-21 21:41    [W:0.026 / U:32.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site