Messages in this thread | | | Date | Mon, 21 Nov 2005 15:52:39 +0000 | From | Russell King <> | Subject | Re: 2.6.15-rc1-mm2 -- Bad page state at free_hot_cold_page (in process 'aplay', page c18eef30) |
| |
On Mon, Nov 21, 2005 at 03:46:50PM +0000, Hugh Dickins wrote: > So another of my patches in -rc1-mm2 made the PageCompound technique > available always, no longer under #ifdef CONFIG_HUGETLB_PAGE: so that > get_page and put_page on the later constituents of the high-order > page get redirected to the first one, and it should work okay again. > > Except that I'd missed that you actually have to choose to have your > high-order pages supplied as compound pages, by passing __GFP_COMP. > Since I wasn't passing that, they still weren't allocated as compound > pages, so were still being freed too soon - and the PG_reserved flag > found while freeing gave rise to the "Bad page state" messages seen.
Does this mean that in arch/arm/mm/consistent.c, we should also set __GFP_COMP ? Should we be doing that today?
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |