lkml.org 
[lkml]   [2005]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/37] dvb: add alternate stv0297-driver
Michael Krufky <mkrufky@m1k.net> wrote:
>
> +#define abs64(x) (x) < 0 ? -(x) : (x);

Needs parentheses around the whole thing.

This should go into include/linus/kernel.h, after labs(), methinks.

> +static s64 div64(s64 dividend,s64 divisor)

hm. If we really need a 64-by-64 divide then it shouldn't be hidden in a dvb
driver, please. I bet we have a few in the tree already, actually.

So it'd be appreciated if someone could take a shot at generating a generic
version of this. It'll need to be inlined for 64-bit arches, out-of-line
for 32-bit.

It'll also need to be permanently wired into the kernel, alas. We cannot
tell at compile time whether it'll be needed :( EXPORT_SYMBOL() it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-03 04:43    [W:0.043 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site