Messages in this thread | | | From | "Kris Katterjohn" <> | Subject | Re: [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c; kernel 2.6.14 | Date | Wed, 2 Nov 2005 18:48:59 -0800 |
| |
Forgive me because this is one of my first attempts at anything related to the kernel, but...
1) How would I go about benchmarking this? 2) If the out-of-line code is executed anyway (since load_pointer() calls __load_pointer()), would it really effect it very much?
I've been programming as a hobby for a few years, but I never really worried about inlining my code. Most likely because when I was learning C, I was using books etc. that were written before C99 was out.
Thanks
----- Original Message ----- From: Herbert Xu [mailto:herbert@gondor.apana.org.au] Subject: Re: [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c; kernel 2.6.14 > Kris Katterjohn <kjak@ispwest.com> wrote: > > I wasn't actually changing it to add performance, but to make the code look > > cleaner. The new load_pointer() is virtually the same as having the seperate > > functions that are currently there, but the code, I think, is "better looking". > > If you look at the current net/core/filter.c and then my patched version, the > > steps are done in the exact same order and same way, but all in that one > > function. > > You've just changed an out-of-line function (__load_pointer) into an > inlined function. There may be a cost to that. > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |