Messages in this thread | | | From | Herbert Xu <> | Subject | Re: [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c; kernel 2.6.14 | Date | Thu, 03 Nov 2005 12:50:29 +1100 |
| |
Kris Katterjohn <kjak@ispwest.com> wrote: > Another patch for net/core/filter.c by me. I merged __load_pointer() into > load_pointer(). I don't see a point in having two seperate functions when > both functions are really small and load_pointer() calls __load_pointer(). > Renamed the variable "k" to "offset" since that's what it is, and in > skb_header_pointer() it's "offset". > > This patch is a diff from kernel 2.6.14
This code path is performance-critical so you should benchmark your changes.
In this particular case, __load_pointer is the unlikely case and therefore it wasn't inlined.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |