Messages in this thread | | | Date | Wed, 02 Nov 2005 22:18:13 +0100 | From | matthieu castet <> | Subject | Re: [PATCH] Eagle and ADI 930 usb adsl modem driver |
| |
matthieu castet wrote: > Hi Greg, >>> +/* >>> + * sometime hotplug don't have time to give the firmware the >>> + * first time, retry it. >>> + */ >>> +static int sleepy_request_firmware(const struct firmware **fw, >>> + const char *name, struct device *dev) >>> +{ >>> + if (request_firmware(fw, name, dev) == 0) >>> + return 0; >>> + msleep(1000); >>> + return request_firmware(fw, name, dev); >>> +} >> >> >> >> No, use the async firmware download mode instead of this. That will >> solve all of your problems. >> >> > Thanks, but does userspace will retry if it fails the first time ? > The device needs the firmware quickly and after 3-5 seconds without it, > it goes berserk. > In request_firmware_nowait, when kernel_thread failed, where fw_work is freed ? Aren't there a memleack ?
Matthieu
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |