lkml.org 
[lkml]   [2005]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] slab: extract slabinfo header printing to separate function
Pekka Enberg wrote:

> #ifdef CONFIG_PROC_FS
>
>-static void *s_start(struct seq_file *m, loff_t *pos)
>+static inline void print_slabinfo_header(struct seq_file *m)
>
>
Why inline? I try to avoid adding inline wherever possible. inline is
actually always_inline force_inline
compiler_we_know_it_better_this_must_be_inlined.
I only use inline in the hot path (kmem_cache_alloc/kmalloc+free) and
where I know that lots of code will be optimized away due to constant
propagation. In this case, there is no reason to force the compiler to
inline the function, thus I wouldn't add an inline.

--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-19 13:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site