lkml.org 
[lkml]   [2005]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RFC][PATCH 4/8] Fix a bug in scsi_get_command
    Testing this patch series uncovered a small bug in scsi_get_command.  This
    patch fixes that bug.

    -Matt
    scsi_get_command() attempts to write into a structure that may not have been
    successfully allocated. Move this write inside the if statement that ensures
    we won't panic the kernel with a NULL pointer dereference.

    Signed-off-by: Matthew Dobson <colpatch@us.ibm.com>

    Index: linux-2.6.15-rc1+critical_pool/drivers/scsi/scsi.c
    ===================================================================
    --- linux-2.6.15-rc1+critical_pool.orig/drivers/scsi/scsi.c 2005-11-15 13:45:38.000000000 -0800
    +++ linux-2.6.15-rc1+critical_pool/drivers/scsi/scsi.c 2005-11-17 16:49:54.279656112 -0800
    @@ -265,10 +265,10 @@ struct scsi_cmnd *scsi_get_command(struc
    spin_lock_irqsave(&dev->list_lock, flags);
    list_add_tail(&cmd->list, &dev->cmd_list);
    spin_unlock_irqrestore(&dev->list_lock, flags);
    + cmd->jiffies_at_alloc = jiffies;
    } else
    put_device(&dev->sdev_gendev);

    - cmd->jiffies_at_alloc = jiffies;
    return cmd;
    }
    EXPORT_SYMBOL(scsi_get_command);
    \
     
     \ /
      Last update: 2005-11-18 20:43    [W:0.022 / U:3.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site