lkml.org 
[lkml]   [2005]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 3/5] slab: extract slabinfo header printing to separate function
    From
    Date

    This patch extracts slabinfo header printing to a separate function
    print_slabinfo_header() to make s_start() more readable.

    Signed-off-by: Matthew Dobson <colpatch@us.ibm.com>
    Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
    ---

    slab.c | 45 +++++++++++++++++++++++++--------------------
    1 file changed, 25 insertions(+), 20 deletions(-)

    Index: 2.6/mm/slab.c
    ===================================================================
    --- 2.6.orig/mm/slab.c
    +++ 2.6/mm/slab.c
    @@ -3369,32 +3369,37 @@ next:

    #ifdef CONFIG_PROC_FS

    -static void *s_start(struct seq_file *m, loff_t *pos)
    +static inline void print_slabinfo_header(struct seq_file *m)
    {
    - loff_t n = *pos;
    - struct list_head *p;
    -
    - down(&cache_chain_sem);
    - if (!n) {
    - /*
    - * Output format version, so at least we can change it
    - * without _too_ many complaints.
    - */
    + /*
    + * Output format version, so at least we can change it
    + * without _too_ many complaints.
    + */
    #if STATS
    - seq_puts(m, "slabinfo - version: 2.1 (statistics)\n");
    + seq_puts(m, "slabinfo - version: 2.1 (statistics)\n");
    #else
    - seq_puts(m, "slabinfo - version: 2.1\n");
    + seq_puts(m, "slabinfo - version: 2.1\n");
    #endif
    - seq_puts(m, "# name <active_objs> <num_objs> <objsize> <objperslab> <pagesperslab>");
    - seq_puts(m, " : tunables <limit> <batchcount> <sharedfactor>");
    - seq_puts(m, " : slabdata <active_slabs> <num_slabs> <sharedavail>");
    + seq_puts(m, "# name <active_objs> <num_objs> <objsize> "
    + "<objperslab> <pagesperslab>");
    + seq_puts(m, " : tunables <limit> <batchcount> <sharedfactor>");
    + seq_puts(m, " : slabdata <active_slabs> <num_slabs> <sharedavail>");
    #if STATS
    - seq_puts(m, " : globalstat <listallocs> <maxobjs> <grown> <reaped>"
    - " <error> <maxfreeable> <nodeallocs> <remotefrees>");
    - seq_puts(m, " : cpustat <allochit> <allocmiss> <freehit> <freemiss>");
    + seq_puts(m, " : globalstat <listallocs> <maxobjs> <grown> <reaped> "
    + "<error> <maxfreeable> <nodeallocs> <remotefrees>");
    + seq_puts(m, " : cpustat <allochit> <allocmiss> <freehit> <freemiss>");
    #endif
    - seq_putc(m, '\n');
    - }
    + seq_putc(m, '\n');
    +}
    +
    +static void *s_start(struct seq_file *m, loff_t *pos)
    +{
    + loff_t n = *pos;
    + struct list_head *p;
    +
    + down(&cache_chain_sem);
    + if (!n)
    + print_slabinfo_header(m);
    p = cache_chain.next;
    while (n--) {
    p = p->next;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-11-18 18:30    [W:0.025 / U:128.472 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site