Messages in this thread | | | Subject | Re: [PATCH] ipw2200: disallow direct scanning when device is down (was: Linuv 2.6.15-rc1) | From | Zhu Yi <> | Date | Thu, 17 Nov 2005 13:59:04 +0800 |
| |
On Wed, 2005-11-16 at 21:55 +0200, Pekka Enberg wrote: > Yi, please consider applying the included patch.
The patch looks good to me. Thanks Pekka!
-yi
> [PATCH] ipw2200: disallow direct scanning when device is down > > The function ipw_request_direct_scan() should bail out when the device > is down. This patch fixes an lockup caused by wpa_supplicant > triggering ipw_request_direct_scan() while the driver was in a middle > of a reset due to firmware errors. > > Thanks to Zilvinas Valinskas for reporting the bug and helping me > debug it. > > Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> > --- > > ipw2200.c | 4 ++++ > 1 file changed, 4 insertions(+) > > Index: 2.6/drivers/net/wireless/ipw2200.c > =================================================================== > --- 2.6.orig/drivers/net/wireless/ipw2200.c > +++ 2.6/drivers/net/wireless/ipw2200.c > @@ -8926,6 +8926,10 @@ static int ipw_request_direct_scan(struc > struct ipw_scan_request_ext scan; > int err = 0, scan_type; > > + if (!(priv->status & STATUS_INIT) || > + (priv->status & STATUS_EXIT_PENDING)) > + return 0; > + > down(&priv->sem); > > if (priv->status & STATUS_RF_KILL_MASK) { >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |