lkml.org 
[lkml]   [2005]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [linux-usb-devel] [PATCH 02/02] USB: add dynamic id functionality to USB core
On Thu, Nov 17, 2005 at 12:19:43PM -0500, Alan Stern wrote:
> On Thu, 17 Nov 2005, Greg KH wrote:
>
> > > > + fields = sscanf(buf, "%x %x", &idVendor, &idProduct);
> > > > + if (fields < 0)
> > > > + return -EINVAL;
> > >
> > > Don't you want to test (fields < 2)?
> >
> > No, it's ok to just specify the vendor, if you want a product of 0 :)
> >
> > PCI does it this way too.
>
> Well, in that case shouldn't you test (fields < 1)?

Yeah, good point. I've also changed it to be < 2, as it doesn't really
make sense to have a product number of 0.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-18 02:54    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site