Messages in this thread | | | Date | Thu, 17 Nov 2005 23:18:25 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/4] add compat_ioctl methods to dasd |
| |
On Thu, Nov 17, 2005 at 01:27:32PM +0100, Martin Schwidefsky wrote: > blkdev_ioctl is explicitly called with a NULL file pointer. That can't > work with block device drivers that use unlocked ioctls. We'd need to > create a struct file with at least a valid f_dentry->d_inode->i_bdev > chain in ioctl_by_bdev to make it work with unlocked ioctls. Not nice ..
Yes, you're right. Looks like we finally need to do the long-planned sanitizing of the blkdev ioctl interface first.
Let's drop the patch for now.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |