lkml.org 
[lkml]   [2005]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/10] kdump: export per cpu crash notes pointer through sysfs
    Vivek Goyal <vgoyal@in.ibm.com> wrote:
    >
    > + /*
    > + * Might be reading other cpu's data based on which cpu read thread
    > + * has been scheduled. But cpu data (memory) is allocated once during
    > + * boot up and this data does not change there after. Hence this
    > + * operation should be safe. No locking required.
    > + */
    > + get_cpu();
    > + addr = __pa(per_cpu_ptr(crash_notes, cpunum));
    > + rc = sprintf(buf, "%Lx\n", addr);
    > + put_cpu();

    I don't think the get_cpu() and put_cpu() are needed here?
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-17 23:09    [W:0.030 / U:88.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site