lkml.org 
[lkml]   [2005]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: PATCH: Fix poor pointer math in devinet_sysctl_register
From
From: Andrew Morton <akpm@osdl.org>
Date: Wed, 16 Nov 2005 22:14:12 -0800

> "Jordan Crouse" <jordan.crouse@amd.com> wrote:
> > @@ -1454,7 +1454,7 @@ static void devinet_sysctl_register(stru
> > return;
> > memcpy(t, &devinet_sysctl, sizeof(*t));
> > for (i = 0; i < ARRAY_SIZE(t->devinet_vars) - 1; i++) {
> > - t->devinet_vars[i].data += (char *)p - (char *)&ipv4_devconf;
> > + t->devinet_vars[i].data += (int)((char *)p - (char *)&ipv4_devconf);
>
> Confused. These appear to be equivalent (on 32-bit CPUs, anyway).

Indeed, please describe the exact failure case when posting
such patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-17 08:16    [W:0.038 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site