![]() | |||||||||||||
Messages in this thread |
Paul Jackson wrote: > Two changes to the setting of the ALLOC_CPUSET flag in > mm/page_alloc.c:__alloc_pages() > > 1) A bug fix - the "ignoring mins" case should not be honoring > ALLOC_CPUSET. This case of all cases, since it is handling a > request that will free up more memory than is asked for (exiting > tasks, e.g.) should be allowed to escape cpuset constraints > when memory is tight. > > 2) A logic change to make it simpler. Honor cpusets even on > GFP_ATOMIC (!wait) requests. With this, cpuset confinement > applies to all requests except ALLOC_NO_WATERMARKS, so that > in a subsequent cleanup patch, I can remove the ALLOC_CPUSET > flag entirely. Since I don't know any real reason this > logic has to be either way, I am choosing the path of the > simplest code. > Hi, I think #1 is OK, however I was under the impression that you introduced the exception reverted in #2 due to seeing atomic allocation failures?! -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-11-15 09:52 [from the cache] ©2003-2008 | |||||||||||||