Messages in this thread | | | Subject | Re: [PATCH 1/4] add compat_ioctl methods to dasd | From | Martin Schwidefsky <> | Date | Tue, 15 Nov 2005 15:51:17 +0100 |
| |
On Sat, 2005-11-12 at 10:33 +0100, Christoph Hellwig wrote: > On Fri, Nov 04, 2005 at 11:16:52PM +0100, Christoph Hellwig wrote: > > all dasd ioctls are directly useable from 32bit process, thus switch > > the dasd driver to unlocked_ioctl/compat_ioctl and get rid of the > > translations in the global table. > > ping on all the four s390 compat_ioctl patches. These are few of the > remaining arch compat_ioctl bits and I'd really really like to get rid > of them soonish.
Current status on the four patches: 1) dasd ioctl patch didn't compile (missing semicolon after lock_kernel()) and doesn't work after fixing the compile problem. It's a problem with the bdev->bd_disk->private_data which is NULL at the time the partition detection code calls the BIODASDINFO and HDIO_GETGEO ioctl with ioctl_by_bdev. I don't see an easy way to fix this right now. 2) fs3270 ioctl patch is fine. Fullscreen test works after fixing the independent class_device_create problem (NULL argument missing, patch will follow). 3) remove TIOCGSERIAL/TIOCSSERIAL patch. Fine with me. 4) tape ioctl patch. Not yet sure about this one. Need to ask Stefan Bader.
-- blue skies, Martin
Martin Schwidefsky Linux for zSeries Development & Services IBM Deutschland Entwicklung GmbH
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |