![]() | |||||||||||||
Messages in this thread Patch in this message |
The 'uinput' driver doesn't work well in 2.6.15-rc1. It triggers this complaint: printk(KERN_WARNING "input: device %s is statically allocated, will not register\n" "Please convert to input_allocate_device() or contact dtor_core@ameritech.net\n", dev->name ? dev->name : "<Unknown>"); The following patch fixes it for me, but I'm not convinced it is correct. I would expect it to need a special 'free' routine to match the special 'alloc' routine, but I couldn't easily find one. NeilBrown Signed-off-by: Neil Brown <neilb@suse.de> ### Diffstat output ./drivers/input/misc/uinput.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff ./drivers/input/misc/uinput.c~current~ ./drivers/input/misc/uinput.c --- ./drivers/input/misc/uinput.c~current~ 2005-11-14 14:34:56.000000000 +1100 +++ ./drivers/input/misc/uinput.c 2005-11-14 15:17:01.000000000 +1100 @@ -199,10 +199,9 @@ static int uinput_open(struct inode *ino spin_lock_init(&newdev->requests_lock); init_waitqueue_head(&newdev->requests_waitq); - newinput = kmalloc(sizeof(struct input_dev), GFP_KERNEL); + newinput = input_allocate_device(); if (!newinput) goto cleanup; - memset(newinput, 0, sizeof(struct input_dev)); newdev->dev = newinput; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-11-14 06:14 [from the cache] ©2003-2008 | |||||||||||||