Messages in this thread Patch in this message |  | | | Date | Mon, 14 Nov 2005 18:42:30 +0800 | | From | Yan Zheng <> | | Subject | [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...) |
The "score.rule++" doesn't make any sense for me. According to codes above, I think it should be "hiscore.rule++;" .
Signed-off-by: Yan Zheng<yanzheng@21cn.com>
Index: net/ipv6/addrconf.c ============================================================ --- a/net/ipv6/addrconf.c 2005-11-13 12:23:06.000000000 +0800 +++ b/net/ipv6/addrconf.c 2005-11-14 18:29:27.000000000 +0800 @@ -1045,9 +1045,10 @@ int ipv6_dev_get_saddr(struct net_device } #endif /* Rule 8: Use longest matching prefix */ - if (hiscore.rule < 8) + if (hiscore.rule < 8) { hiscore.matchlen = ipv6_addr_diff(&ifa_result->addr, daddr); - score.rule++; + hiscore.rule++; + } score.matchlen = ipv6_addr_diff(&ifa->addr, daddr); if (score.matchlen > hiscore.matchlen) { score.rule = 8; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |