Messages in this thread | | | Date | Mon, 14 Nov 2005 15:25:00 -0800 (PST) | From | Christoph Lameter <> | Subject | Re: [RFC] NUMA memory policy support for HUGE pages |
| |
On Mon, 14 Nov 2005, Adam Litke wrote:
> On Mon, 2005-11-14 at 13:46 -0800, Christoph Lameter wrote: > > This is V2 of the patch. > > > > Changes: > > > > - Cleaned up by folding find_or_alloc() into hugetlb_no_page(). > > IMHO this is not really a cleanup. When the demand fault patch stack > was first accepted, we decided to separate out find_or_alloc_huge_page() > because it has the page_cache retry loop with several exit conditions. > no_page() has its own backout logic and mixing the two makes for a > tangled mess. Can we leave that hunk out please?
It seemed to me that find_or_alloc_huge_pages has a pretty simple backout logic that folds nicely into no_page(). Both functions share a lot of variables and putting them together not only increases the readability of the code but also makes the function smaller and execution more efficient.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |