Messages in this thread Patch in this message | | | From | "Gabriel A. Devenyi" <> | Subject | [RESEND] [PATCH] drivers/char/keyboard.c unsigned comparison | Date | Sat, 12 Nov 2005 16:00:10 -0500 |
| |
keycode is a checked for a value less than zero, but is defined as an unsigned int, and is only called in one place in the kernel, and passed a unsigned int, so this comparison is bogus.
Thanks to LinuxICC (http://linuxicc.sf.net)
This patch applies to Linus' git tree as of 12.11.2005
Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c index 449d029..6e991ea 100644 --- a/drivers/char/keyboard.c +++ b/drivers/char/keyboard.c @@ -198,7 +198,7 @@ int setkeycode(unsigned int scancode, un if (scancode >= dev->keycodemax) return -EINVAL; - if (keycode < 0 || keycode > KEY_MAX) + if (keycode > KEY_MAX) return -EINVAL; if (dev->keycodesize < sizeof(keycode) && (keycode >> (dev->keycodesize * 8))) return -EINVAL; -- Gabriel A. Devenyi ace@staticwave.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |