lkml.org 
[lkml]   [2005]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[RESEND] [PATCH] drivers/net/wireless/airo.c unsigned comparason
    fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless.
    In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the
    current definition.

    Thanks to LinuxICC (http://linuxicc.sf.net).

    This patch applies to linus' git tree as of 03.11.2005

    Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>

    diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
    index 750c016..849ac88 100644
    --- a/drivers/net/wireless/airo.c
    +++ b/drivers/net/wireless/airo.c
    @@ -2040,7 +2040,7 @@ static int mpi_send_packet (struct net_d
    return 1;
    }

    -static void get_tx_error(struct airo_info *ai, u32 fid)
    +static void get_tx_error(struct airo_info *ai, s32 fid)
    {
    u16 status;

    --
    Gabriel A. Devenyi
    ace@staticwave.ca

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-11 14:00    [W:0.020 / U:1.800 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site