lkml.org 
[lkml]   [2005]   [Nov]   [11]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSat, 12 Nov 2005 00:54:44 +0100
FromMichal Piotrowski <>
SubjectRe: [PATCH] nvidiafb: Fix bug in nvidiafb_pan_display
Hi,

On 12/11/05, Antonino A. Daplas <adaplas@gmail.com> wrote:
> nvidiafb_pan_display() is incorrectly using the fields in
> info->var instead of var passed to the function.
>
> Signed-off-by: Antonino Daplas <adaplas@pol.net>
> ---
[snip]
> Looks like a bug in nvidiafb_pan_display() which was revealed when I
> changed the semantics of update_var/update_start.
>
> Try this patch.
>
> Tony
>
>  nvidia.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/drivers/video/nvidia/nvidia.c b/drivers/video/nvidia/nvidia.c
> index 0b40a2a..bee09c6 100644
> --- a/drivers/video/nvidia/nvidia.c
> +++ b/drivers/video/nvidia/nvidia.c
> @@ -1301,7 +1301,7 @@ static int nvidiafb_pan_display(struct f
>         struct nvidia_par *par = info->par;
>         u32 total;
>
> -       total = info->var.yoffset * info->fix.line_length + info->var.xoffset;
> +       total = var->yoffset * info->fix.line_length + var->xoffset;
>
>         NVSetStartAddress(par, total);
>
>
>

Problem fixed. Great thanks.

Regards,
Michal Piotrowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-12 00:57    [from the cache]
©2003-2008