lkml.org 
[lkml]   [2005]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] use ptrace_get_task_struct in various places
Christoph Hellwig <hch@lst.de> wrote:
>
> > In arch/ia64/ia32/sys_ia32.c this patch will cause PTRACE_TRACEME requests
> > to be handled by ptrace_request()
>
> you mean ptrace_get_task_struct?

No, I was referring to this code:

asmlinkage long
sys32_ptrace (int request, pid_t pid, unsigned int addr, unsigned int data)
{
struct task_struct *child;
unsigned int value, tmp;
long i, ret;

lock_kernel();
if (request == PTRACE_TRACEME) {
ret = sys_ptrace(request, pid, addr, data);
goto out;
}

Your patch removes the PTRACE_TRACEME special-case. Consequently
sys32_ptrace() will fall all the way down to the default: case of the
switch statement and will use ptrace_request() instead. And
ptrace_request() doesn't handle PTRACE_TRACEME, so I think it's busted.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-11 01:03    [W:0.063 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site