lkml.org 
[lkml]   [2005]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 14/39] NLKD - kernel trace buffer access
    Date
    On Wed, 09 Nov 2005 15:09:13 +0100, 
    "Jan Beulich" <JBeulich@novell.com> wrote:
    >Debug extension implementation for NLKD to access the kernel trace
    >buffer.

    printk.c | 187 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    1 files changed, 187 insertions(+)

    This is complete overkill in printk.c. The only change required to
    printk is to add a routine which gets the parameters that define the
    buffer, see below from KDB. The rest of the code in your patch belongs
    in the debugger, not in printk.

    #ifdef CONFIG_KDB
    /* kdb dmesg command needs access to the syslog buffer. do_syslog() uses locks
    * so it cannot be used during debugging. Just tell kdb where the start and
    * end of the physical and logical logs are. This is equivalent to do_syslog(3).
    */
    void kdb_syslog_data(char *syslog_data[4])
    {
    syslog_data[0] = log_buf;
    syslog_data[1] = log_buf + log_buf_len;
    syslog_data[2] = log_buf + log_end - (logged_chars < log_buf_len ? logged_chars : log_buf_len);
    syslog_data[3] = log_buf + log_end;
    }
    #endif /* CONFIG_KDB */

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-10 12:04    [W:0.019 / U:94.776 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site