lkml.org 
[lkml]   [2005]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/8] Inline 3 functions
    On Thu, Nov 10, 2005 at 07:04:22PM +0100, Oliver Neukum wrote:
    > Am Donnerstag, 10. November 2005 18:38 schrieb Adrian Bunk:
    > > > So are you suggesting that we don't mark these functions 'inline', or are
    > > > you just pointing out that we'll need to drop the 'inline' if there is ever
    > > > another caller?
    > >
    > > I'd suggest to not mark them 'inline'.
    >
    > It seems you have found one more use for sparse. How about a tag
    > like __single_inline that will cause a warning if a function having it
    > is called from more than one place?

    Why should such a function be manually marked "inline" at all?

    If a static function is called exactly once it is the job of the
    compiler to inline the function.

    > Regards
    > Oliver

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-10 19:23    [W:0.021 / U:0.876 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site