lkml.org 
[lkml]   [2005]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Fastboot] Re: [PATCH] [KDUMP] pending interrupts problem
From
On Thu, 27 Oct 2005, Eric W. Biederman wrote:
>
> Alex Lyashkov <umka@sevcity.net> writes:
>
> > seems to bad patch. you dereference pointer (1) before check to NULL(2).
>
> Duh. I forgot to delete the earlier references.
> That should have been...

Thank you Eric, the patch you resent has fixed the problem,
which originally happened on vanilla 2.6.13.

But, on such an unusual case, I prefer to mark it unlikely() and
output some warning message.

> + /* Ignore spurious IPIs */
> + if (!call_data)
> + return;

if (unlikely(!call_data)) {
printk(KERN_WARNING "spurious IPI on CPU#%d, ignored\n",
smp_processor_id());
return;
}

Please take this if you like it, Eric. I have also tested this
printk-added code.

Regards,

--
OBATA Noboru (noboru.obata.ar@hitachi.com)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-01 10:16    [W:0.040 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site