Messages in this thread | | | Date | Tue, 1 Nov 2005 22:04:52 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c |
| |
Hi!
> > > Oh, it can be done on-the-fly in > > > sys_put_this_stuff_where_appropriate(image data) (at the expense of one > > > redundant check per call). > > > > Yes, but it is still ugly, as you keep some context across the > > syscalls. > > That depends on how you implement the interface. If you insist on using > ioctls then yes, it's ugly. However, if it is a file in sysfs, for example, > then you have well-defined open(), close(), read() and write() operations > and it is assumed you will keep some context accross eg. write()s.
I was trying to keep kernel code simple. Yes, if we do it sysfs based, that's probably not a problem. I'm not sure if nice sysfs interface can be done without excessive ammount of code. Pavel -- Thanks, Sharp! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |