Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation | Date | Tue, 1 Nov 2005 00:55:31 -0500 |
| |
On Tuesday 01 November 2005 00:50, Ian Wienand wrote: > On Tue, Nov 01, 2005 at 12:14:56AM -0500, Dmitry Torokhov wrote: > > It seems that the change is pretty straightforward... Could you please try > > this one? > > Ahh, ok! I thought that that comment meant it was deliberately > ignoring the return of input_register_device (by which time it's got > memory, irq's, io, etc), but now I see it's void anyway. So why not > just move the setup right to the top? >
Now you are leaking memory if something else fails... FOr example when chip is not present.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |