Messages in this thread | | | Date | Mon, 31 Oct 2005 21:27:42 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 5/5] Swap Migration V5: sys_migrate_pages interface |
| |
Christoph Lameter <clameter@sgi.com> wrote: > > ... > Changes V3->V4: > - Add Ray's permissions check based on check_kill_permission(). > > ... > + /* > + * Permissions check like for signals. > + * See check_kill_permission() > + */ > + if ((current->euid ^ task->suid) && (current->euid ^ task->uid) && > + (current->uid ^ task->suid) && (current->uid ^ task->uid) && > + !capable(CAP_SYS_ADMIN)) { > + err = -EPERM; > + goto out; > + }
Obscure. Can you please explain the thinking behind putting this check in here? Preferably via a comment... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |