lkml.org 
[lkml]   [2005]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC] gfp flags annotations - part 6 (simple parts of fs/*)
Al Viro writes:
> A bug had been caught in relayfs code -
> mem = vmap(buf->page_array, n_pages, GFP_KERNEL, PAGE_KERNEL);
> in fs/relayfs/buffers.c is bogus (the third argument of vmap() is unrelated
> to gfp flags). s/GFP_KERNEL/VM_MAP/, presumably? Author Cc'd, code in
> question left alone for now.
>

Yes, looks like a stupid typo that luckily wasn't affecting the
outcome because the GFP_KERNEL value happens to not cause any false
test outcomes in the vmap code. I'll submit a patch momentarily.

Thanks for catching this.

Tom



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-09 17:44    [W:0.062 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site