Messages in this thread | | | Subject | Re: [patch 1/2] acpiphp: allocate resources for adapters with bridges | From | Kristen Accardi <> | Date | Fri, 07 Oct 2005 11:05:44 -0700 |
| |
On Fri, 2005-10-07 at 10:59 -0700, Greg KH wrote: > On Fri, Oct 07, 2005 at 10:45:46AM -0700, Kristen Accardi wrote: > > Allocate resources for adapters with p2p bridges. > > > > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com> > > > > diff -uprN -X linux-2.6.14-rc2/Documentation/dontdiff linux-2.6.14-rc2/drivers/pci/hotplug/acpiphp_glue.c linux-2.6.14-rc2-kca1/drivers/pci/hotplug/acpiphp_glue.c > > --- linux-2.6.14-rc2/drivers/pci/hotplug/acpiphp_glue.c 2005-08-28 16:41:01.000000000 -0700 > > +++ linux-2.6.14-rc2-kca1/drivers/pci/hotplug/acpiphp_glue.c 2005-09-28 10:43:15.000000000 -0700 > > @@ -58,6 +58,9 @@ static LIST_HEAD(bridge_list); > > > > static void handle_hotplug_event_bridge (acpi_handle, u32, void *); > > static void handle_hotplug_event_func (acpi_handle, u32, void *); > > +static void acpiphp_sanitize_bus(struct pci_bus *bus); > > +static void acpiphp_set_hpp_values(acpi_handle handle, struct pci_bus *bus); > > These are not static functions, but functions somewhere else in the > kernel. Please put their function prototypes in a header file > somewhere. You also need to EXPORT_SYMBOL_GPL() them so that the > hotplug driver can use them when it is loaded as a module. > > thanks, > > greg k-h
Actually, these functions are present as static functions in acpiphp_glue.c, and only used in acpiphp_glue.c, so I don't believe I need to export them or make them non static (they are static currently).
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |