![]() | |||||||||||||
Messages in this thread |
On Wed, Oct 05 2005, Jesper Juhl wrote: > On Tuesday 04 October 2005 08:21, Jens Axboe wrote: > [snip] > > This is a mess. So NACK on this patch. And why are you changing the > [snip] > > Hi Jens, > > Sorry about the messy previous patch. Would you consider something like the > one below instead? It only makes a few changes, not lots of different ones in > the same patch and it also only makes changes that I hope you'll agree are > useful. :) > > > Remove some unneeded casts. > Avoid an assignment in the case of kmalloc failure. > Break a few instances of if (foo) whatever; into two lines. Looks much better, thanks. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-10-05 11:36 [from the cache] ©2003-2008 | |||||||||||||