lkml.org 
[lkml]   [2005]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/7] Fragmentation Avoidance V16: 002_usemap
From
From: Mel Gorman <mel@csn.ul.ie>
Date: Wed, 5 Oct 2005 15:45:57 +0100 (IST)

> + unsigned int type = 0;
...
> + bitidx = pfn_to_bitidx(zone, pfn);
> + usemap = pfn_to_usemap(zone, pfn);
> +

There seems no strong reason not to use "unsigned long" for "type" and
besides that will provide the required alignment for the bitops
interfaces. "unsigned int" is not sufficient.

Then we also don't need to thing about "does this work on big-endian
64-bit" and things of that nature.

Please audit your other bitops uses for this issue.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-06 01:41    [from the cache]
©2003-2011 Jasper Spaans