Messages in this thread | | | Date | Thu, 6 Oct 2005 00:49:59 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH][Fix] swsusp: avoid possible page tables corruption during resume on x86-64 |
| |
Hi!
> Summary ========= > The following patch makes swsusp avoid the possible temporary corruption of > page translation tables during resume on x86-64. This is achieved by creating > a copy of the relevant page tables that will not be modified by swsusp and can > be safely used by it on resume.
Andi, this means swsusp fails 50% of time on x86-64. I believe we even have one report in suse bugzilla by now... Could we get this somehow merged?
> Index: linux-2.6.14-rc3-git5/kernel/power/swsusp.c > =================================================================== > --- linux-2.6.14-rc3-git5.orig/kernel/power/swsusp.c 2005-10-05 21:12:41.000000000 +0200 > +++ linux-2.6.14-rc3-git5/kernel/power/swsusp.c 2005-10-05 21:24:50.000000000 +0200 > @@ -672,7 +672,6 @@ > return 0; > > page = pfn_to_page(pfn); > - BUG_ON(PageReserved(page) && PageNosave(page)); > if (PageNosave(page)) > return 0; > if (PageReserved(page) && pfn_is_nosave(pfn)) {
Rafael, are you sure? This will clash with snapshot.c split and probably belongs to some other patch. Pavel -- if you have sharp zaurus hardware you don't need... you know my address - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |