![]() | ||||||||||
Messages in this thread |
On Tue, Oct 04 2005, Jesper Juhl wrote: > On 10/4/05, Alexey Dobriyan <adobriyan@gmail.com> wrote: > > On Tue, Oct 04, 2005 at 12:17:56AM +0200, Jesper Juhl wrote: > > > --- linux-2.6.14-rc3-git3-orig/drivers/ide/ide-cd.c > > > +++ linux-2.6.14-rc3-git3/drivers/ide/ide-cd.c > > > > What was wrong with these ones? [snipping the rest] > > > > Nothing much, simply that as far as I know, the common coding style is > that function declarations/definitions should be on one line and if > that line can't fit in 80 chars then arguments are moved to the next > line and indented by two tabs. That's the style I believe is the most > official one (if such a thing exists), so that's the style I changed > everything throughout the file to obey. That is by no means the common style. What I usually do is indent the arguments so the match up with the first line. > > > static int cdrom_log_sense(ide_drive_t *drive, struct request *rq, > > > - struct request_sense *sense) > > > + struct request_sense *sense) This is a mess. So NACK on this patch. And why are you changing the driver version for non-functional changes? And I prefer a space after a cast. And regardless of what others may think, I do indent cases in a switch unless it's tight for space. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2005-10-04 04:23 [W:0.189 / U:0.050 seconds] ©2003-2008 Jasper Spaans | ||||||||||