lkml.org 
[lkml]   [2005]   [Oct]   [4]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] i386: move apic init in init_IRQs
From(Eric W. Biederman)
DateTue, 04 Oct 2005 09:48:01 -0600
"Maciej W. Rozycki" <macro@linux-mips.org> writes:

> On Tue, 4 Oct 2005, Eric W. Biederman wrote:
>
>> -	if (enable_local_apic < 0)
>> -		clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
>
>  I think this should stay.

lapic_disable() already does this.  I am just testing the results.

>> +	if (enable_local_apic < 0) {
>> +		printk(KERN_INFO "Apic disabled\n");
>
>  Capitalisation. ;-)
>
>  Otherwise it seems reasonable -- provided it works for you. ;-)

So what should the capitalization be? "APIC disabled\n" ?

Sorry.

Eric


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-04 15:51    [from the cache]
©2003-2008