Messages in this thread | | | Date | Tue, 1 Nov 2005 12:20:17 +0800 | From | Yan Zheng <> | Subject | Re: [PATCH][MCAST]IPv6: Check packet size when process Multicast Address and Source Specific Query |
| |
> I think this should be modelled after the equivalent code in IGMPv3. > See igmp_heard_query() in net/ipv4/igmp.c. For ease of maintenance, > the code should be structured exactly the same way, except for > necessary differences, of course. > > I haven't seen enough context yet, but I think you need to check > for the query header itself, too (as done in IGMPv3). > > I'm reviewing your other patches as well. > > +-DLS
Yes . It's better to drop invalid query earlier. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |