Messages in this thread | | | From | Rob Landley <> | Subject | Re: [PATCH] fix floppy.c to store correct ro/rw status in underlying gendisk | Date | Mon, 31 Oct 2005 17:17:21 -0600 |
| |
On Monday 31 October 2005 05:57, Evgeny Stambulchik wrote: > Jon Masters wrote: > > Let me know if this fixes it for you - should bomb out now if you try. > > The error isn't the cleanest (blame mount), but it does fail. > > This works fine, thanks! For what it worth, though, mount -o remount,rw > says remounting read-only yet still returns success. (Opposite to > busybox, which now says "Permission denied" - rather misleading, but at > least it fails).
That sounds like the string translation of EPERM returned by libc's strerror(). (At busybox we're frugal bastards; we don't include text messages when we can get the C library to provide them for us. :)
But yeah, we're sticklers for correct behavior, and only attempt to remount readonly if we get EACCES or EROFS, not _just_ because we attempted a read/write mount and it failed. (And yes, I personally tested this corner case. We haven't started on an automated regression test script for mount yet because running it would require root access, but it's on the todo list as we upgrade the test suite in our Copious Free Time...)
Rob - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |