lkml.org 
[lkml]   [2005]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 17/20] inflate: mark some arrays as initdata
    On Mon, Oct 31, 2005 at 10:43:01PM +0000, Russell King wrote:
    > On Mon, Oct 31, 2005 at 02:54:51PM -0600, Matt Mackall wrote:
    > > inflate: mark some arrays as INITDATA and define it in in-core callers
    >
    > This breaks ARM. Our decompressor has some rather odd requirements
    > due to the way we support PIC - it's PIC text with fixed data.
    >
    > This means that all fixed initialised data must be "const" or initialised
    > by code. This patch breaks that assertion.

    It would have been helpful if you quoted the patch.

    +#ifndef INITDATA
    +#define INITDATA
    +#endif
    ...
    -static const u16 cplens[] = {
    +static INITDATA u16 cplens[] = {
    3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 15, 17, 19, 23, 27, 31,
    35, 43, 51, 59, 67, 83, 99, 115, 131, 163, 195, 227, 258, 0, 0
    };

    etc..

    I think for ARM, we can simply do -DINITDATA=const, yes?

    --
    Mathematics is the supreme nostalgia of our time.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-01 00:05    [W:0.021 / U:0.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site