Messages in this thread | | | Subject | Re: [PATCH against 2.6.14] truncate() or ftruncate shouldn't change mtime if size doesn't change. | From | Trond Myklebust <> | Date | Mon, 31 Oct 2005 08:37:38 -0500 |
| |
On Mon, 2005-10-31 at 07:51 -0500, Trond Myklebust wrote: > This should normally be OK as far as NFS is concerned since we usually > end up revalidating the attribute cache in the lookup() code, but you > could imagine a networked filesystem that does not do this. I'd > therefore prefer if such checks were made in the filesystem itself.
Actually, I'm wrong about this. ftruncate() doesn't do a lookup/lookup_revalidate, so the current NFS code may end up using stale attribute data.
Moving the checks to the VFS will just make that problem unfixable, though.
Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |