lkml.org 
[lkml]   [2005]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectPATCH for promise ide controllers
Date
Hi all,
while read data from the hard disk and a read error
occurs as reported below, the kernel will hang in ide-io.c
in the function try_to_flush_leftover_data()
in the statement hwif->INSW(IDE_DATA_REG, buffer, wcount<<1).

On the console 10 appears this messages:
hde: dma_intr: status=0x59 { DriveReady SeekComplete DataRequest Error }
hde: dma_intr: error=0x01 { AddrMarkNot Found }, LBAsect=1253209, high=0, low=1253209, sector=1252805


This strange behaviour seems to be a special issue with promise controllers
especially with the models ID_PROMISE_20268 (thats was my personal test case)
and ID_PROMISE_20269 as reported years ago in the internet.

My suggestion is to leave off try_to_flush_leftover_data() for
promise controllers.

Unfortunately it is hard to reproduce this test case if you don't have
such a disk controller and such a disk fault.

---------------------------------------------------------------------------
--- ./linux-2.6.13/drivers/ide/ide-io.c.ORIG 2005-08-29 01:41:01.000000000 +0200
+++ ./linux-2.6.13/drivers/ide/ide-io.c 2005-10-12 15:50:20.000000000 +0200
@@ -445,10 +445,44 @@
/* help it find track zero */
rq->errors |= ERROR_RECAL;
}
+ /* 2005/09/10 --ms, this case was left here */
+ else if (err & MARK_ERR) {
+ /* retry because AddrMarkNotFound */
+ rq->errors |= ERROR_RECAL;
+ }
}

if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ)
- try_to_flush_leftover_data(drive);
+ /* 2005-09-10 --ms
+ * To avoid a system hang in hwif->INSW(IDE_DATA_REG, buffer, wcount<<1),
+ * possibly caused by a bug in the disk controller, hence we check
+ * here the disk controller model.
+ */
+ switch(HWIF(drive)->pci_dev->device) {
+ // case PCI_DEVICE_ID_PROMISE_20277:
+ // case PCI_DEVICE_ID_PROMISE_20276:
+ // case PCI_DEVICE_ID_PROMISE_20275:
+ // case PCI_DEVICE_ID_PROMISE_20271:
+ // case PCI_DEVICE_ID_PROMISE_20270:
+ case PCI_DEVICE_ID_PROMISE_20269:
+ case PCI_DEVICE_ID_PROMISE_20268: // my pci device
+ printk(KERN_WARNING "%s: ide_ata_error, PROMISE_202*\n", drive->name);
+ /* try_to_flush_leftover_data() will hang in various cases like:
+ * ABRT_ERR DriveStatusError
+ * ICRC_ERR BadCRC BadSector
+ * ECC_ERR UncorrectableError (will hang too)
+ * ID_ERR SectorIdNotFound
+ * TRK0_ERR TrackZeroNotFound
+ * MARK_ERR AddrMarkNotFound (this was my actual testcase)
+ */
+ if (!(err & (ABRT_ERR | ICRC_ERR | ECC_ERR | ID_ERR | TRK0_ERR | MARK_ERR)))
+ try_to_flush_leftover_data(drive);
+
+ break;
+ default:
+ try_to_flush_leftover_data(drive);
+ }
+

if (hwif->INB(IDE_STATUS_REG) & (BUSY_STAT|DRQ_STAT))
/* force an abort */
---------------------------------------------------------------------------
--- ./linux-2.6.13/drivers/ide/ide-iops.c.ORIG 2005-08-29 01:41:01.000000000 +0200
+++ ./linux-2.6.13/drivers/ide/ide-iops.c 2005-10-12 16:02:44.000000000 +0200
@@ -1103,7 +1103,8 @@
if (drive->current_speed >= XFER_SW_DMA_0)
(void) HWIF(drive)->ide_dma_on(drive);
} else
- (void)__ide_dma_off(drive);
+ // (void)__ide_dma_off(drive);
+ return; // 2005-09-10 --ms, no crc-error, leave speed as it is!
#endif
}

---------------------------------------------------------------------------
Signed-off-by: Manfred Scherer <manfred.scherer.mhm@t-online.de>
-------------------------------------------------------------------------
BTW I think the 2.4 kernel will have the same problem.
-------------------------------------------------------------------------
Manfred Scherer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-30 16:12    [W:0.054 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site