Messages in this thread | | | Date | Sun, 30 Oct 2005 20:52:54 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2/3] swsusp: move snapshot-handling functions to snapshot.c |
| |
Hi!
> This patch moves the snapshot-handling functions remaining in swsusp.c > to snapshot.c (ie. it moves the code without changing the functionality). >
I'm sorry, but I acked this one too quickly. I'd prefer to keep "relocate" code where it is, and define "must not collide" as a part of interface. That will keep snapshot.c smaller/simpler, and I plan to eventually put responsibility for relocation to userspace.
That should simplify error handling at least: data structures needed for relocation can be kept in userspace memory, and therefore we do not risk memory leak in case something goes wrong.
Pavel
-- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |