Messages in this thread | | | Date | Sun, 30 Oct 2005 20:23:24 +0100 | From | Pavel Machek <> | Subject | Re: amd64 bitops fix for -Os |
| |
Hi!
> This patches fixes a bug that comes up when compiling the kernel for > x86_64 optimizing for size. It affects 2.6.14 for sure, but I'm > pretty sure many earlier kernels are affected as well.
Is the same problem in i386, too?
> --- arch/x86_64/lib/bitops.c~ 2005-10-27 22:02:08.000000000 -0200 > +++ arch/x86_64/lib/bitops.c 2005-10-29 18:24:27.000000000 -0200 > @@ -1,5 +1,11 @@ > #include <linux/bitops.h> > > +#define BITOPS_CHECK_UNDERFLOW_RANGE 0 > + > +#if BITOPS_CHECK_UNDERFLOW_RANGE > +# include <linux/kernel.h> > +#endif
Could you drop the ifdefs? Nice for debugging but we don't want them in mainline.
Plus you want to add signed-off-by: header and send it to ak@suse.de. Pavel
-- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |