Messages in this thread | | | Date | Mon, 3 Oct 2005 12:27:14 -0700 | From | Deepak Saxena <> | Subject | Re: [PATCH] [I2C] kmalloc + memset -> kzalloc conversion |
| |
On Oct 01 2005, at 13:32, Jiri Slaby was caught saying: > On 10/1/05, Deepak Saxena <dsaxena@plexity.net> wrote: > > + iface = (struct keywest_iface *) kzalloc(tsize, GFP_KERNEL); > cast isn't needed > > + if (!(smbuses = (void *)kzalloc(2*sizeof(struct nforce2_smbus), > > GFP_KERNEL))) > cast from (void*) to (void*)? No...
Agree...but I'm just doing kzalloc changes for now and if I started cleaning every piece of ugly or bloated code in the kernel, I would spend the rest of my life looking at drivers/ACPI.
~Deepak
-- Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net
Even a stopped clock gives the right time twice a day. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |