Messages in this thread | | | Date | Sat, 29 Oct 2005 19:26:11 -0700 | From | Paul Jackson <> | Subject | Re: [PATCH]: Clean up of __alloc_pages |
| |
> > 2) The can_try_harder flag values were driving me nuts. > > Please instead use a second argument 'gfp_high', which will nicely > match zone_watermark_ok, and use that consistently when converting > __alloc_pages code to use get_page_from_freelist. Ie. keep current > behaviour.
Well ... I still don't understand what you're suggesting, so I guess I will have to wait for an actual patch incorporating it.
Are you also objecting to converting "can_try_harder" to an enum, and getting the values in order of desperation? If so, I don't why you object.
And there is still the issue that I don't think cpuset constraints should be applied in the last attempt before oom_killing for GFP_ATOMIC requests.
I will await the next version of the patch, and see if it meets my concerns. I am missing a couple too many clues to add more at this point.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |