Messages in this thread | | | Date | Thu, 27 Oct 2005 10:36:58 -0600 | From | Matthew Wilcox <> | Subject | Re: AMD 8131 and MSI quirk |
| |
On Thu, Oct 27, 2005 at 08:08:45AM -0700, Roland Dreier wrote: > Matthew> Perhaps the right thing to do is to change pad2 (in > Matthew> struct pci_bus) to bus_flags and make bit 0 > Matthew> PCI_BRIDGE_FLAGS_NO_MSI ? > > Seems reasonable, but I'm still not sure how to implement this. Where > does this bit get set and propagated to secondary buses?
We can propagate it to secondary busses in pci_alloc_child_bus(). We inherit parent->ops and parent->sysdata at this point, we can also inherit parent->whatever_flags_we_like.
Setting it from the quirk is a bit more yucky. I *think* we're going to have to walk the PCI tree, given that it's a FIXUP_FINAL. Maybe it needs to not be a FIXUP_FINAL ... a FIXUP_HEADER might get it set early enough for it to propagate through that mechanism. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |