Messages in this thread | | | Subject | Re: [PATCH] Infineon TPM: move infineon driver off pci_dev | From | Roland Dreier <> | Date | Thu, 27 Oct 2005 15:03:49 -0700 |
| |
Andrew, a few comments on your trivial comments:
> -static int tpm_atml_send(struct tpm_chip *chip, u8 * buf, size_t count) > +static int tpm_atml_send(struct tpm_chip *chip, u8 *buf, size_t count)
There's still an extra space there I think.
> - data = kmalloc(READ_PUBEK_RESULT_SIZE, GFP_KERNEL); > + data = kxalloc(READ_PUBEK_RESULT_SIZE, GFP_KERNEL);
When did we add kxalloc()? And what does it do?
> -ssize_t tpm_write(struct file * file, const char __user * buf, > +ssize_t tpm_write(struct file * file, const char __user *buf,
Why delete one space between * and buf but not the one between * and file?
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |