Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] kill massive wireless-related log spam | Date | Wed, 26 Oct 2005 17:04:14 +0200 |
| |
On Wednesday 26 October 2005 06:28, Jeff Garzik wrote:
> Change this to printing out the message once, per kernel boot.
It doesn't do that. It prints it once every 2^32 calls. Also the ++ causes unnecessary dirty cache lines in normal operation.
-Andi > > diff --git a/net/core/wireless.c b/net/core/wireless.c > index d17f158..271ddb3 100644 > --- a/net/core/wireless.c > +++ b/net/core/wireless.c > @@ -455,10 +455,15 @@ static inline struct iw_statistics *get_ > > /* Old location, field to be removed in next WE */ > if(dev->get_wireless_stats) { > - printk(KERN_DEBUG "%s (WE) : Driver using old /proc/net/wireless support, please fix driver !\n", > - dev->name); > + static int printed_message; > + > + if (!printed_message++) > + printk(KERN_DEBUG "%s (WE) : Driver using old /proc/net/wireless support, please fix driver !\n", > + dev->name); > + > return dev->get_wireless_stats(dev); > } > + - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |