Messages in this thread |  | | | Date | Wed, 26 Oct 2005 23:43:59 +0200 | | From | Jesper Juhl <> | | Subject | Re: [PATCH] kill massive wireless-related log spam |
| |
On 10/26/05, J.A. Magallon <jamagallon@able.es> wrote: > > On 2005.10.26, at 17:23, Jesper Juhl wrote: > > > On 10/26/05, Andi Kleen <ak@suse.de> wrote: > > > >> On Wednesday 26 October 2005 06:28, Jeff Garzik wrote: > >> > >> > >>> Change this to printing out the message once, per kernel boot. > >>> > >> > >> It doesn't do that. It prints it once every 2^32 calls. Also > >> > > > > I noted that as well. How about just using something along the > > lines of > > > > static unsigned char printed_message = 0; > > if (!printed_message) { > > printk(...); > > printed_message++; > > } > > Sorry, but why not the old good > > printed_message = 1 > > ?? > What kind of microoptimization is that ? > Does it really matter? I needed to pick one of printed_message=1; or printed_message++; the end result is the same, so I just picked one at random. But now that you mention it, I guess ++ would turn into "inc" which should be faster than an assignment... but it *doesn't matter*... I was not trying to optimize anything, just make the code work properly - as in, only ever print the message once...
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |