lkml.org 
[lkml]   [2005]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ohci1394 PCI fixup for Toshiba laptops
On Tue, Oct 25, 2005 at 10:19:16AM -0700, Jesse Barnes wrote:
> On Tuesday, October 25, 2005 12:02 am, Stefan Richter wrote:
> > Jesse Barnes wrote:
> > > +static void __devinit pci_post_fixup_toshiba_ohci1394(struct
> > > pci_dev *dev) +{
> > > + if (dmi_check_system(toshiba_ohci1394_dmi_table))
> > > + return; /* only applies to certain Toshibas (so far) */
> > > +
> > > + /* Restore config space on Toshiba laptops */
> > > + mdelay(10);
> > > + pci_write_config_word(dev, PCI_CACHE_LINE_SIZE,
> > > toshiba_line_size);
> >
> > Shouldn't this read
> >
> > if (!dmi_check_system(toshiba_ohci1394_dmi_table))
> > return;
> > ^ ?
> >
> > dmi_check_system returns the number of matches.
>
> Doh! Yes, it should be (I tested an earlier version, then decided to
> reverse the logic and return, oops).
>
> Here's an updated version.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Care to resend with the full changelog information too, so I can apply
it?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-25 19:25    [W:0.047 / U:11.276 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site